David Jerleke

Results 118 comments of David Jerleke

@soham2k06 but we still need to bump the packages in [this PR](https://github.com/shadcn-ui/ui/pull/2286#issuecomment-1906619438) and someone also has to approve it I think: - #2286 Of course, if everything else has been...

@louispelarrey and @MWhiteFearless you need to mock the following API:s to solve the problem: - `IntersectionObserver` - `matchMedia` - `resizeObserver` Maybe that's the culprit? Feel free to [grab the mocks](https://github.com/davidjerleke/embla-carousel/tree/master/packages/embla-carousel/src/__tests__/mocks)...

Thanks @SoyDiego for approving 👍! Is there anything else I have to do before we can merge this?

@realwagyu thank you for your contribution 👍. I will review this when possible. Thanks for your patience. Best, David

@shadcn I think this issue will improve the UX a lot and **shouldn’t be closed**. The related PR is also finished and is only waiting to be merged. Best, David

Hello from the Embla side! My two cents after my conversation with @zaaakher and his efforts: > `embla-carousel` is technically already installed behind the scene because `embla-carousel-react` depends on it...

@huri3l I think that’s a good idea. Since this isn’t merged yet, let just bump all Embla Carousel packages to `v8.0.0-rc20`. @Xxsource98 would you mind doing that?

@Xxsource98 just curious, don’t mean to rush you or anything: Is this PR waiting for something before it can be merged?

@vicantwin screenshots with fragments of code are impossible to debug. Please provide a GitHub repository with a reduced test case (unnecessary details stripped) and instructions on how to reproduce the...