ui icon indicating copy to clipboard operation
ui copied to clipboard

[Carousel]: When tapping the previous/next buttons multiple times it triggers page zoom

Open davidjerleke opened this issue 1 year ago • 1 comments

Hello from the Embla side, I hope you're all doing well 👋!

Issue description

When tapping the carousel previous and next buttons multiple times on an iOS device, it sometimes triggers an unwanted page zoom.

Steps to reproduce

  • Browse to the carousel page on an iOS device like an iPhone.
  • Tap on the next button twice or more to scroll through the carousel slides.
  • See the page gets zoomed which probably isn't what you wanted to do.

Suggested solution

I believe adding touch-action: manipulation; here and here solves the problem. As MDN describes it:

Enable panning and pinch zoom gestures, but disable additional non-standard gestures such as double-tap to zoom. Disabling double-tap to zoom removes the need for browsers to delay the generation of click events when the user taps the screen.

Thank you for your time!

Best, David

davidjerleke avatar Jan 15 '24 12:01 davidjerleke

@davidjerleke thanks for reporting it, I would work on this issue.

mukul-turing avatar Jan 16 '24 13:01 mukul-turing

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.

shadcn avatar Feb 26 '24 23:02 shadcn

@shadcn I think this issue will improve the UX a lot and shouldn’t be closed. The related PR is also finished and is only waiting to be merged.

Best, David

davidjerleke avatar Feb 27 '24 05:02 davidjerleke

@shadcn reopen this? PR is not merged yet.

davidjerleke avatar Mar 07 '24 16:03 davidjerleke