David Hewitt

Results 1495 comments of David Hewitt

I ran into this in the PyO3 test suite. I opened https://github.com/dtolnay/trybuild/pull/305 specifically for this case.

Looks like adding a deprecation is discouraged in a patch, so will keep this for 0.25. Think we'll start merging all those changes in shortly, I just want to get...

With #5021 prepped, I think this is ready for merge, if others agree this is a good idea?

Will close this as it looks like `inline-snapshot` is still not thread-safe. Can resume once upstream is fixed.

If I recall correctly, in https://github.com/pydantic/pydantic-core/pull/1062 I added the "constants" mode of `ser_json_inf_nan` because it is potentially nonstandard behaviour but also at the same time very useful. We had to...

We are now prioritising this work as "BaseStruct" - I hope to have an experimental version of this merged as soon as Pydantic 2.13.

👍 I will do my best to help investigate this Friday if you haven't cracked it sooner!

So that makes it plausible it's a wider issue than just PyO3? I have spent most of the day trying to get a thread sanitizer build working, but sadly... >...

That said https://github.com/rust-lang/rust/blob/9c4ff566babe632af5e30281a822d1ae9972873b/compiler/rustc_target/src/spec/targets/x86_64_unknown_linux_musl.rs#L13-L17 ```rust base.supported_sanitizers = SanitizerSet::ADDRESS | SanitizerSet::CFI | SanitizerSet::LEAK | SanitizerSet::MEMORY | SanitizerSet::THREAD; ``` suggests this combination is deliberately allowed, maybe it's an issue with my build attempts...

https://github.com/llvm/llvm-project/issues/78452 - so it seems like we can't get thread sanitizers are just not supported by musl, not specific to rust? I'm going to park investigating given there's a scipy...