pydantic-core icon indicating copy to clipboard operation
pydantic-core copied to clipboard

bump inline snapshot, re-enable for freethreaded tests

Open davidhewitt opened this issue 10 months ago • 1 comments

Change Summary

inline-snapshot 0.20.3 made black formatting thread-safe, let's see if this allows us to re-enable...

Related issue number

N/A

Checklist

  • [ ] Unit tests for the changes exist
  • [ ] Documentation reflects the changes where applicable
  • [ ] Pydantic tests pass with this pydantic-core (except for expected changes)
  • [ ] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

davidhewitt avatar Mar 07 '25 20:03 davidhewitt

CodSpeed Performance Report

Merging #1665 will improve performances by 38.12%

Comparing dh/free-threaded-snapshot (01c3338) with main (d8be765)

Summary

⚡ 1 improvements
✅ 156 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_strict_union_error_core 45.1 µs 32.7 µs +38.12%

codspeed-hq[bot] avatar Mar 07 '25 20:03 codspeed-hq[bot]

Will close this as it looks like inline-snapshot is still not thread-safe. Can resume once upstream is fixed.

davidhewitt avatar Sep 23 '25 18:09 davidhewitt