David Gräff

Results 150 comments of David Gräff

I've noticed that I haven't got any read/write examples. That's something that needs to be added for sure. Might be end of the next week though.

I agree. I haven't used a local firestore emulator yet, because it is so easy to just setup a -dev mirror / have a developer variant of an existing firestore....

The API of this crate to manage users on firebase is very rudimentary only. It is possible to update users entries later on, there is just no implementation yet.

Maybe it makes sense to have two duration parameters (oauth token 1..60 minutes and cookie duration 1min..14 days) for the create method? I'm not sure if everyone would appreciate if...

Wasm is not on my personal target list, but as soon as all dependencies (tokio, reqwest, oauth) support wasm this crate will do so as well :)

It's trickier than you think to provide an async and sync API without too much code duplication and without the async version to allocate. I'm haven't figured out all pieces...

Hey, thanks for the patch. I think I do not understand it though. Currently the duration of the cookie is a parameter to the create function. You are replacing that...

Thanks for the report. I think you are right, I will look into this / a PR is very welcome as well.

Hi thanks for the feedback. When I had designed the API this way of having an own Result type within an error module was kind of state of the art...

I will add a `FirestoreResult` to the libraries directly/non-namespaced exported types as an alias for errors::Result. (also recommended by https://doc.rust-lang.org/rust-by-example/error/result/result_alias.html) It is still idiomatic Rust to have a Result type...