David

This code is triggering an assertion ``` thread 26160 panic: reached unreachable code /home/david/dev/official-zig/src/Module.zig:5563:36: 0x55d0af82fe4c in Module.analyzeFnBody (zig2) error.GenericPoison => unreachable, ^ /home/david/dev/official-zig/src/Module.zig:4291:40: 0x55d0af81096a in Module.ensureFuncBodyAnalyzed (zig2) var air =...

This is no longer happening. Could it be possible to have a small test which covers this case to add it to the behavior tests?

I think this has to do with softfloat. When I tried to do some math in my kernel it also had a similar recursion codegen bug. I don't remember if...

Doing more digging, when I strip the symbols and set build mode to release fast, I get this: ``` thread 261997 panic: reached unreachable code /home/david/dev/official-zig/src/type.zig:4216:21: 0x55a5644d6368 in type.Type.elemType2 (zig2)...

Similar crash happening in CI failure for https://github.com/ziglang/zig/pull/13173 https://ci.ziglang.org/ziglang/zig/8602/1/3

Does this have anything to do? https://github.com/tianocore/edk2/blob/c6720db5ddffec747bb0b2830e528511b1a4bfb2/OvmfPkg/OvmfPkgIa32X64.dsc#L116

Is anything else required to merge this PR?

Maybe rebase against master to pass the CI?

Stack trace: ``` thread 27665 panic: attempt to use null value /home/david/dev/official-zig/src/Sema.zig:14019:29: 0x562265d504cb in Sema.zirClosureGet (zig2) scope = scope.parent.?; ^ /home/david/dev/official-zig/src/Sema.zig:728:68: 0x562265bab07d in Sema.analyzeBodyInner (zig2) .closure_get => try sema.zirClosureGet(block, inst),...

That is the reasoning of the change, since currently the action is unable to pick the right binary due to it being hardcoded.