David Fowler
David Fowler
Agreed. I haven't figured this out yet but I'll assign this one to myself to spend some time here (I usually copy and paste a bunch of these files from...
> ProtocolReader currently uses an async state machine in ReadAsync per call, it could implement IValueTaskSource to amortize this cost and reuse the ProtocolReader itself to avoid the per operation...
> What about a generic version of ProtocolReader? Funny, it used to be generic then it was made non generic. Maybe it makes sense to have both. > Also, how...
One reason the generic reader was remove was to allow composing protocols like this https://github.com/davidfowl/BedrockFramework/blob/08273ead26e7989649bff8ada7bfa98d2fc95388/src/Bedrock.Framework.Experimental/Protocols/HttpClientProtocol.cs#L19. Http reads the header then reads the body and those end up being different message...
> Should be able to add a sensitively flag Only do Task.Wait and Result by default, the other locks should be opt-in (aggressive mode).
It's likely you need to manually add the application parts (not just log them). The default way that applications parts are found is using `IHostingEnvironment.ApplicationName` and this defaults to `Assembly.GetEntryAssembly().Name`...
One more thing unrelated to your question but it's bugging me, you should signal back to native code when the application has started. Right now you're calling RunAsync but instead...
> @davidfowl Would it make sense to have a check in ASP.NET that the application parts are populated from an existing assembly? Currently the above API probably returns null or...
More information here https://github.com/davidfowl/BedrockTransports
Thatāll be a separate assembly.