David Figatner
David Figatner
This works great. Outside of the necessary server changes, is there anything else that makes this a POC and not ready for review? We'll also need this ported to JS...
Awesome. Works wonderfully.
Please resolve conflicts (hopefully last one)
Thanks. Good change
This looks super nice. A few things I noticed on the functionality: * there's a noticeable difference between the rendered text vs Monaco when wrapping. Probably has to do with...
> @davidfig I wanted this also, but I was not sure about implementation. This requires a flag in schema to denote whether a row height is manually set or set...
> Auto row resizing also sets a value in SheetsOffsets and this value propagates to client and renderer ... so value is defined in both cases whether manual resize or...
Hey Ayush, I was using this branch to build fit-numbers, and it doesn't seem like the vertical alignment is working properly. CellLabel is getting the right verticalAlign value, but I...
The horizontal alignment for Monaco does not work consistently. It sometimes places the cursor in weird places compared to the text when alignment is not left. It looks like the...
If we're going to add the horizontal alignment to the editor, we also have to properly support right align. The input box needs to be aligned to the right side...