David Figatner

Results 248 comments of David Figatner

I cherry picked the changes. There are a few failing tests. @AyushAgrawal-A2 can you take a look? The failures are probably my fault, but I don't understand the code well...

Code coverage looks good!

Large numbers have better precision:

Can you add tests for the multiple async. Any problems with the counter?

Both bugs are fixed.

> Cutoff point calculation cuts off text sometimes It's a super subtle bug. I'll revisit it down the road. It's not new.

I changed the percent that we stop drawing gridlines to 25% (it was 10%). See if that helps perf.

The perf should be much better now. I also reverted the change to when we stop showing the grid lines.

What does multiplayer footer message show in these scenarios? I can't see why it wouldn't save to the offline storage regardless of the multiplayer connection.