david graff
david graff
I’ll take a look at this but in case I don’t someone please remind me
also what's the output when you run flake8 with the following codes: `E203, E266, E501, W503, F403, F401, E741`? I'd only lint the files you've touched to avoid going crazy
what command are you running?
can you run it on all files you've touched in this PR and fix any linting issues for code that was yours?
looks like a test is failing but it's the chemprop web test. If you can confirm that running `pytest -v` results in only that failure on your machine (and *no*...
that's expected, most of those files haven't been formatted before. after adding some unit tests, this PR should be good to go
it's a good start with the test functions! On that note, can you think of corner/boundary/edge cases for your loss function? Also, can you include some tests for your uncertainty...
yep just waiting on @cjmcgill to give it the green light
@kevingreenman @oscarwumit i think this is a good idea- anyone wanna take a stab at it?
thanks for the PR! will take a detailed look later, but quickly re: `flake8`. The repo is undergoing a major overhaul and yes there are a ton of violations. To...