David Dixon
David Dixon
> In general, I think the changes are good to help reduce the build time. Most of the code movement makes sense! > > I would encourage checking a few...
> Is `DEPENDS_EXPLICIT_ONLY` applicable to the uses of `add_custom_command`? In theory, it would be possible to run the Tensile build in parallel with the build of the library when compiling...
> Are the tests not applicable to rhel9 ? Not clear why you are disabling them..... if you want to ignore them temporarily for purposes of promotion you can just...
We keep removing "optional" dependencies from the requirements files. This hasn't been a problem up to now but if requirements.txt does not contain joblib and we use the fallback then...
@stellaraccident when do we want this one to go in?
@stellaraccident How/why where tests added to this PR? Also, we will need to get @KKyang or @jichangjichang to approve as well.
> should we notify build team to limit the number of parallel jobs at their end? I don't think this will be a problem because we are using cpu nodes...
Hi @dwiddows - new python bindings were added to the library. Try from the tensilelite directory `pip install rocisa/`. Note that rocisa is a subdirectory in tensilelite with a setup.py....
@trixirt we are in the process of overhauling build systems. We just merged a PR a few days ago that completely removes use of those scripts. See 56a26228bf9d595dad74598ce43b2831572fefc3 on develop...
@aviallon this is a known issue that we are working on. We will follow up over the next few weeks once we have the relevant changes in.