David Chin

Results 15 comments of David Chin

Hey @tymochko, maybe you can try passing in a `formatLabel` function, which is responsible for converting numeric values into formatted text?

Thanks for your work! However, I think hiding/showing labels should be done using CSS instead. Can you achieve the same result using CSS?

Hey @oyeanuj, thanks for your reply! Few good points there. However, I still think controlling the visual appearance of a component should be done using CSS. I'm saying this because,...

Yeah, that's a good idea. I'd make it an option though so people can opt in rather than have the tooltips showing by default.

Yeah that's cool, thanks for bringing this to my attention. I'm happy to accept a PR that improves the accessibility of the component. 😄

Hey @oyeanuj and @jedwards1211, thanks for bringing this to my attention. Sorry I couldn't respond to you earlier as Github notifications tend to get lost in my inbox. Anyway, I...

Yeah, I think there's an issue with the definition file.

Hi @ppeg34, we won't be able to replace the aforementioned dependencies without a significant rewrite. And the replacement wouldn't guarantee a significant reduction in size, considering we need to retain...

Hi @hiren-ganatra, I'm not sure if it'd work if you just pull in a library from npm as its version might not be compatible with the version we're using. Anyway,...

Hi @hiren-ganatra, it seems to me that the container (with `AmazonPayButton` element ID) doesn't exist when the method is called. In order for the button to be inserted into the...