David Cassany Viladomat

Results 82 comments of David Cassany Viladomat

Hi, just done the pull request. I did not have time now to make the unit test, I foresee that maybe tomorrow I am gonna have time to make them....

just an idea, but probably something similar to what was suggested in https://github.com/GoogleContainerTools/container-diff/pull/233#pullrequestreview-120040358 would do the trick. Instead of trying to guess the layers to compare, let user select them...

@nkubala I can try to make a PR for that, probably it will take me some days to find the spare cycles to do it, but I'll try to come...

Thanks for your comment, however, meanwhile I have been digging further in the code (my first contact with go language, so I suffering a little here :^P ) and I...

> This would alleviates CI to need to wait for each other, however we should still run _some_ smoke tests for ISOs, packer etc to guarantee that we have still...

Just to update: ```bash $ qemu-img create -f raw disk.img 30G $ sudo losetup -f --show disk.img /dev/loop0 $ sudo elemental install --docker-image quay.io/costoolkit/releases-green:cos-system-0.8.2-6 /dev/loop0 $ sudo losetup -d /dev/loop0...

Thanks for reporting the issue. Please note that `luet-makeiso` is not dropped, it can still be used it's just moved away form the Makefile iso's target. But you can certainly...

I am also in favor of dropping mtree support, I see little gain on it and something we, and probably everyone else, is likely to end up skipping or bypassing....

> we should streamline it's approach offering mtree capabilities directly from the elemental-cli, for example (fictional example ahead): This is nice. However I see little benefit on that, I struggle...

Hi @j-landru thanks for reporting. Looks like the error might be before actually calling `xorriso`. It just complaints about missing artifacts, so I suspect you might miss some artifacts. Could...