David Brochart
David Brochart
Still not :disappointed:
But it looks I cannot merge :disappointed:
I opened https://github.com/jupyterlab/jupyter-collaboration/pull/345 which is a POC that uses this PR to enable RTC on the default JupyterLab drive, by registering a content provider for the RTC procotol. Since no...
[Failures](https://github.com/jupyterlab/jupyterlab/actions/runs/10738595322/job/29782508372?pr=16744) seem to be unrelated?
> Thank you for working on it @davidbrochart! Some feedback on the code. I think it might be worth adding a simple test to ensure that swapping the provider works....
I re-added the optional `sharedModelFactory` attribute on the `IDrive`, for backwards compatibility. If the drive provides one, it will be used. Otherwise, the one from the content provider is used,...
> It would also be worth taking the time to document the different between drives and contents providers Where would that go? I don't see a section for drives in...
I'm a bit reluctant about adding some documentation for content providers. They are not extension points in the sense of a token. The first use-case is the removal of the...
Thanks again for the review @krassowski. I guess marking the API as experimental means we don't write official documentation yet? I think it would be wise, until we make sure...
> * Why there are now two ways for providing additional content? Content providers add flexibility, as you can use multiple protocols within the same drive. Previously, you had to...