David Brochart
David Brochart
Nice, looking forward to it!
Thanks for mentioning that @blink1073, I think a contents change notifier could use this notifications extension. Right now I don't even need the file change notification to be sent to...
> Do you know if issue also exists in `jupyter/notebook`? Good point, there is no issue with classic Notebook, i.e. a first GET request to `http://localhost:8889/edit/file.txt?token=the_token` sets the `_xsrf` cookie.
Hey @mwakaba2, no I didn't find any reference to XSRF in Jupyter Notebook: https://github.com/jupyter/notebook/search?q=xsrf. It's actually using jupyter-server now I think, so I don't know why it behaves differently than...
Thanks for looking into this @reoono. Indeed accessing `self.xsrf_token` sets the cookie. But I think what we want is to set it on the *first* request. If we set it...
> 2. `http://localhost:8889/api/sessions?token=the_token` : 200, with cookies (_xsrf and login cookie) When launching `jupyter server` I get a `500`: ``` Traceback (most recent call last): File "/home/david/mambaforge/envs/jupyter_server/lib/python3.10/site-packages/tornado/web.py", line 1683, in...
Thanks @reoono for pushing on this. I am quite confused actually, and I'm not even sure the XSRF cookie should have anything to do with authentication. Maybe we should take...
> I verified that watchfiles is available on conda-forge I packaged it yesterday :smile:
Indeed, but I think now almost everything is done in Rust using [this library](https://github.com/notify-rs/notify).
@kevin-bates I had a previous experience with `watchdog`, my conclusion was that it is much better to work with `watchgod` (and thus `watchfiles`) in an async context. Also, `watchfiles` has...