David Brochart
David Brochart
I'm planning to merge today.
Same [error](https://github.com/jupyterlab/jupyter-collaboration/actions/runs/11269344248/job/31337772188?pr=353): ``` src/yprovider.ts:6:35 - error TS2307: Cannot find module '@jupyter/collaborative-drive' or its corresponding type declarations. 6 import { IDocumentProvider } from '@jupyter/collaborative-drive'; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` I guess the published package...
Oh my bad, yes the code is there. Then I don't know what is wrong.
> > I guess the published package is useless without code. > > What do you mean by "without code"? The package was published from this branch directly. Actually yes,...
I published `@jupyter/collaborative-drive` v3.0.0-beta.7, and there is no `IDocumentProvider` in `lib/tokens.js` [here](https://www.npmjs.com/package/@jupyter/collaborative-drive/v/3.0.0-beta.7?activeTab=code). It is in `lib/tokens.d.ts` but it's not enough, right?
In the end, I just think that `jlpm build` is needed because the test in [docprovider](https://github.com/jupyterlab/jupyter-collaboration/blob/08df1514354abef1e0351738814804f5091977e5/packages/docprovider/src/__tests__/yprovider.spec.ts) now needs `@jupyter/collaborative-drive` through [yprovider.ts](https://github.com/jupyterlab/jupyter-collaboration/blob/4c685cab15d845911e0f6f608322cd3351bca0fc/packages/docprovider/src/yprovider.ts#L6), so it has to be compiled.
I'll take the risk to merge this PR and release jupyter-collaboration v3.0.0beta7. We can still revert the changes and release v3.0.0beta8 if it doesn't work.
@ianthomas23 would you mind looking at this?
Since the release of v7.0.0a1, subshell tests timeout on Windows. It would be great if you could look at it too.
> Do such plugins need be in the jupyverse repo ? No, they can live in another repo. > Or is there a way to add one by config before...