David A. Russo

Results 24 comments of David A. Russo

Hi Micky, I think you're right, making literal translations of proper nouns can introduce ambiguity. Unless there's a commonly used German translation of the spec. terminology (such as would appear...

A change has been committed for the next release which should, in many cases, allow JHOVE to continue processing files after a module has failed to parse a file, such...

I believe this may be fixed in the next release of JHOVE (v1.26), of which there is currently [a release candidate](https://software.openpreservation.org/releases/jhove/1.26/jhove-xplt-installer-1.26.0-RC2.jar) available if you'd like to test and see before...

Nice. Looking through the Title property, I can see that it's encoded as UTF-16, and includes escaped parentheses _and_ at least one escaped newline, so the parser is probably over-running...

Just as a heads up to help with any future merging, I think there is also a possibly less elegant [fix](https://github.com/openpreserve/jhove/pull/634/commits/d223a280804968bb2875d40879baf2a86589e1fd) for this in my [XML module review PR](https://github.com/openpreserve/jhove/pull/634).

Hi Peter, thanks for your super helpful review. This all sounds a little familiar, since I did a review of the XML module code a year or two ago, but...

Cheers. Does [this comment](https://github.com/openpreserve/jhove/pull/634/commits/a878b6a057e83599948f50b504ee214bd00f253e#diff-0bb60a598ec5b7c469cbd2aa683672019b2b9d0d8911b8d86049d49db009eb2bR296) relate to the relative entity resolution issue you're describing? If so, from what I remember/wrote, it sounds like there's a hacky solution in the module at...

We might not need to add an external dependency for identification purposes since each module already contains the logic necessary to validate the signatures of the formats they support. I...

Yes, another example of signature matching can be seen [here](https://github.com/openpreserve/jhove/blob/v1.22.1/jhove-modules/wave-hul/src/main/java/edu/harvard/hul/ois/jhove/module/WaveModule.java#L353-L382) in the Wave module. And more compartmentalized in the GIF module [here](https://github.com/openpreserve/jhove/blob/v1.22.1/jhove-modules/gif-hul/src/main/java/edu/harvard/hul/ois/jhove/module/GifModule.java#L218) and, apparently, [here](https://github.com/openpreserve/jhove/blob/v1.22.1/jhove-modules/gif-hul/src/main/java/edu/harvard/hul/ois/jhove/module/GifModule.java#L354). But more importantly for how...

The relevant part of the PDF (1.7) spec. seems to be section 7.3.4.2 "Literal Strings", which includes: >A conforming writer may split a literal string across multiple lines. The REVERSE...