david-perez
david-perez
Ah yeah you're right. I've pushed a commit to implement [`FromIterator`](https://doc.rust-lang.org/std/iter/trait.FromIterator.html) instead. I've also restored the `From` implementation, since removing it is a breaking change, but there shouldn't be a...
Do we have [a protocol test](https://github.com/smithy-lang/smithy/blob/main/smithy-aws-protocol-tests/model/restJson1/malformedRequests/malformed-union.smithy) establishing this behavior? I thought that was why the label was added.
Worth noting that these sections incorrectly reference `application/vnd.amazon.event-stream` (note the dash). * [Get the request content-type of an operation](https://smithy.io/2.0/guides/building-codegen/using-the-semantic-model.html?highlight=vnd#get-the-request-content-type-of-an-operation) * [Get the response content-type of an operation](https://smithy.io/2.0/guides/building-codegen/using-the-semantic-model.html?highlight=vnd#get-the-response-content-type-of-an-operation)
This was addressed in the case of _streaming_ blob shapes in IDL v2 (https://smithy.io/2.0/guides/model-translations/migrating-idl-1-to-2.html#add-the-default-trait-to-streaming-blobs) by forcing the user to add `@required` or `@default`, so I'm going to close this and...
Just to document the decision that was made, the added tests show that no payload is sent if the union has no value.
Isn't deriving a condition key from a resource id superfluous? It's a condition key whose value is identical to the value of the resource id in the request. Why not...
> though I'm curious about your thoughts on [0, 1, 2, 3] vs [2, 3] Personally I think the most useful representation is returning groups of indices: `[[0, 2], [1,...
> If I were implementing this and it requires a non trivial effort, a big performance hit, or a complete rearchitecture of validation or deserialization, I’d ignore the error message...
> It looks like OPTIONAL_DEBUG_SYMBOLS is the best place for these to be propagated at the moment, and since there are no other references to this perhaps it could be...