insta icon indicating copy to clipboard operation
insta copied to clipboard

Make `Filters` constructible from `IntoIterator`s

Open david-perez opened this issue 1 year ago • 2 comments

This just relaxes bounds. Useful to create filters from arrays.

david-perez avatar Sep 07 '23 11:09 david-perez

I am in favor of this change, but I'm a bit worried about now having a generic T implementation there. It might be okay, but then it cannot be implemented for potentially other things in the future. I will think about this change a bit more.

mitsuhiko avatar Oct 08 '23 10:10 mitsuhiko

Ah yeah you're right. I've pushed a commit to implement FromIterator instead. I've also restored the From<Vec<(&'a str, &'a str)>> implementation, since removing it is a breaking change, but there shouldn't be a need for it if we have FromIterator.

david-perez avatar Oct 08 '23 11:10 david-perez

Applied in 1d702385e13cdfc2bf81616c7b4b349501856c12

mitsuhiko avatar Mar 28 '24 10:03 mitsuhiko