David Luna

Results 169 comments of David Luna

> LGTM > > Should we add some note in the README about this package not implementing any semantic convention at the moment? I thought the absence of the section...

> ... will decrease coverage by 0.65%. This is due to no tests are manipulating the hidden properties of the `handle` function of the layers. so the setter is not...

Hi @architgarg95 would you mind to share - the instrumentation code - how do you start the SDK (code inlined in the main file, using --require, ...) - if you're...

Hi @richardlau thanks to pointing out the difference in the docs. I assumed the history table in https://nodejs.org/docs/v20.11.0/api/test.html#test-reporters was for all the reporters in the list. I guess it would...

@sibelius thanks for your contribution into `elastic-apm-node` :) What you propose enforces the specs related to `mongodb` instrumentation ([link](https://github.com/elastic/apm/blob/main/specs/agents/tracing-instrumentation-db.md#mongodb)) for that specific command so indeed we should find a way...

@sibelius I've created https://github.com/elastic/apm-agent-nodejs/pull/3919 to tackle the issue. Feel free to add any feedback there.

It's strange the message tells about a table already existing ``` |error: create table "users" ("id" serial primary key, "user_name" varchar(255)) - relation "users" already exists ``` I could only...

Note: ~concurrency is an issue that make test fail~ turns out it was a timeout problem but it was not clear from the error message.

@trentm I've also updated the test expectations for the latest changes in span names. Now tests are green :)

Hi, the agent does not officially support Bun but this seems an installation issue since `source-map` is a dependency of the agent. I've run your code successfully in my local...