David Alexander

Results 11 comments of David Alexander

I came across an issue today that seems to be related to this one, although slightly different. In my case, the process *does* die in response to `SIGTERM`, but sometimes...

Sorry I still haven't got round to doing a PR with my fix for this. @taxilian, have you tried the commit linked in my comment above to see if it...

I have just taken another look at my fix today and have made a few changes to it - the new version is [here](https://github.com/david-alexander/tsc-watch/commit/a513c14e8ae22d79750890c1fcf744be7b86964b). ~~Please note that I haven't yet...

Yes, I see there is a subtle edge case that I didn't think of, where we try to kill the same set of processes twice. This could cause one of...

Yes, that makes sense and is basically the same as what I was thinking. My idea is slightly different from passing an ID to `killProcesses`, but will have the same...

That looks like it would work, but I have an idea for a different way that might be more readable and therefore less likely to hide bugs / edge cases....

Sorry @taxilian! Same here... have been meaning to get this PR updated. The code changes are basically ready so I'll try to get them pushed today.

I've just pushed my latest changes, but I still need to add some documentation regarding how they work and the rationale for doing it this way. I'll try to get...

@gilamran I understand what you mean about it being hard to get your head around, especially if you aren't familiar with the idea of a "state machine". Personally I do...

Ok, I have taken a close look at your solution and I *think* it covers all the edge cases. However, I still think we can improve on the readability, which...