David Savage

Results 21 comments of David Savage

Sorry yep I wasn't very clear when adding this bug. The link works when a class is in the field. But it would be nice if when you're authoring new...

Rather than large scale changes it might be better in the short term to do a type check on the constructor for Compel to assert that the tokenizers are CLIPTokenizers...

Yep, couple of tweeks to make, forgot to tag it as draft

I'm going to close this merge request in favour of implementing this behaviour https://github.com/modelcontextprotocol/modelcontextprotocol/pull/617 which includes this functionality but addresses some of the concerns around long running requests requiring continous...

Also potential fix for https://github.com/modelcontextprotocol/python-sdk/issues/230

Note the failed check above appears to be due to: https://github.com/modelcontextprotocol/python-sdk/issues/744

I'm going to explore whether this is better implemented as part of behaviour specified in https://github.com/modelcontextprotocol/modelcontextprotocol/pull/617

Tagging @bhosmer-ant I took a pass refactoring my previous merge request to this repo to support https://github.com/modelcontextprotocol/modelcontextprotocol/pull/371 there's definitely some rough edges happy to discuss potential improvments.

Note failed test appears to be due to https://github.com/modelcontextprotocol/python-sdk/issues/744

@bhosmer-ant no problem, just experimenting at the moment, but this feature is really useful in my experiments! Whilst I have your attention could I also highlight https://github.com/modelcontextprotocol/python-sdk/pull/628 for your consideration...