Dave Marshall

Risky Tests

2

Fix them...

Tidy LegacyMockInterface

1

This might need splitting further. Ideally any "internal" methods, i.e. those we use to manage and run the doubles, shouldn't be exposed in the interface. It would be nice to...

**Describe the bug** The Pager implements the Iterator interface, but does not meet the contract. If this is a limitation, it could be noted in the docblock comments. **To Reproduce**...

Build on the good start in 3d729d0, decoupling the actual logic from the console application.

Move console app in to it's own namespace

1

Thoughts on this? It's a shame to miss out on sharing the config/service bootstrap of the web app, but it can be used to show the same application logic (once...

Probably not what you were looking for...

1

...but the first thing I saw was the boolean constructor argument and I didn't like it :) Not sure this is the best fix for it, but you get the...

Discourage disabling verifying peers for the connections

2

I think this should be discouraged and configurable. https://github.com/richsage/RMSPushNotificationsBundle/blob/master/Service/OS/AndroidNotification.php#L75 Ideally it would be configurable by injecting a buzz browser, or even better an interface I can use with any other...