RMSPushNotificationsBundle icon indicating copy to clipboard operation
RMSPushNotificationsBundle copied to clipboard

Discourage disabling verifying peers for the connections

Open davedevelopment opened this issue 12 years ago • 2 comments

I think this should be discouraged and configurable.

https://github.com/richsage/RMSPushNotificationsBundle/blob/master/Service/OS/AndroidNotification.php#L75

Ideally it would be configurable by injecting a buzz browser, or even better an interface I can use with any other http client.

davedevelopment avatar Feb 12 '13 15:02 davedevelopment

Yep, injection of the browser would definitely be a better option than the existing implementation. I can't remember what issues I had with the disabling of the verification to be perfectly honest...

richsage avatar Feb 13 '13 13:02 richsage

Well, I imagine a lot of shared hosts don't allow people to update the php ini, which is where you can set the root certificate things (I forget the details), if whatever you're trying to connect to can be deemed trusted.

davedevelopment avatar Feb 13 '13 14:02 davedevelopment