Dave Cheney

Results 251 comments of Dave Cheney

It’s probably not specified explicitly but implementing cause then returning nil is not expected. I don’t know if it will be possible to retrofit this, I’ll have to survey the...

Hi Greg, What would this new `RootCause` function do?

ooh, that's bad. If you can make a repro so I can turn it into a test that would be much appreciated. On Fri, Sep 1, 2017 at 9:39 AM,...

I don't think it's going to be possible to support the `go test all` use case and I'm not sure that the notion of testing _all_ the packages makes sense...

Thank you for highlighting golang/go#26317 , I'll have to change the tests to work in this manner. I don't have an ETA for that, patches welcome.

Not LGTM sorry. Do we need a field on withMessage? Can't you do type assertion instead?

I believe this is no longer required, Keith rolled back the change to runtime.Callers

See #200. I believe that Go 1.12 is supported by this package.

I don't think I want to do this, for example wrapper types like OpError and URL.Error include additional information that would be discarded if the errors package interpreted them as...

I'm sorry, this may be my misunderstanding. It doesn't look like I understand what you are asking. > On 29 Mar 2017, at 00:50, Spencer Nelson wrote: > > Hm,...