Dave Brophy

Fails to correctly handle multi-alias imports.

2

When `dst` automatically manages the imports block, the imports are internally keyed by path. This incorrectly assumes that only one import for each package path is possible. Although very rare,...

Check for fields in externalize, internalize

9

Check for fields before accessing first struct field in externalize and internalize functions. Fixes this bug: https://play.jsgo.io/308c189e795b573511cbc4d4606af6b0a60a065a Note: I don't have node so I can't generated the minified prelude.

EscapingObjects [returns a slice](https://github.com/gopherjs/gopherjs/blob/95deb33d587c9f6e24b494ea9bdf9648c48f9a60/compiler/analysis/escape.go#L9), which is created [from a map](https://github.com/gopherjs/gopherjs/blob/95deb33d587c9f6e24b494ea9bdf9648c48f9a60/compiler/analysis/escape.go#L18-L20) so the order is undefined. It is then [sorted here](https://github.com/gopherjs/gopherjs/blob/95deb33d587c9f6e24b494ea9bdf9648c48f9a60/compiler/utils.go#L372-L377). This PR improves the situation by maintaining the order that...

Missing braces in natives/src/runtime/runtime.go?

1

GoLand is flagging this as a syntax error... https://github.com/gopherjs/gopherjs/blob/8dffc02ea1cb8398bb73f30424697c60fcf8d4c5/compiler/natives/src/runtime/runtime.go#L207 ... it obviously doesn't break anything, but perhaps we should correct it?

In compiler.Compile, files should be sorted to ensure reproducible output

2

I noticed that the order of `files` in `compiler.Compile` must be identical to ensure reproducible output. Would sorting them be a good idea? ```go // Files must be in the...

Reproducible output: image/draw

6

While developing jsgo, I noticed that the entire stdlib builds reproducibly apart from `image/draw`. Only the un-minified code shows the problem. This switch statement: https://github.com/golang/go/blob/master/src/image/draw/draw.go#L608-L615 ... the variables `src0$1`, `src0$2`...

Thanks to @magicsong for reporting this in https://github.com/dave/jennifer/issues/49: > `Values(DictFunc)` cannot add comment of each field like following: ``` go opt := &LoginOption { Login : "MUST_EDIT_IT", // [TODO] This...

Inline SVG

16

I'm having trouble getting inline SVG working: ```go vecty.Tag( "svg", vecty.Markup( vecty.Namespace("http://www.w3.org/2000/svg"), vecty.Attribute("width", "14"), vecty.Attribute("height", "16"), vecty.Attribute("viewBox", "0 0 14 16"), ), vecty.Tag( "path", vecty.Markup( vecty.Attribute("fill-rule", "evenodd"), vecty.Attribute("d", "M7 2.3c3.14...

Preserve selection range across element replacements

3

As a follow-on from https://github.com/gopherjs/vecty/issues/47 - we can preserve the cursor position by recording and replacing the selectionStart and selectionEnd properties: ``` start := e.node.Get("selectionStart").Int() end := e.node.Get("selectionEnd").Int() e.node.Set(name, value)...