astrapy icon indicating copy to clipboard operation
astrapy copied to clipboard

[core] Most JSON-y parameters have "null-like" defaults despite no API support

Open erichare opened this issue 2 years ago • 2 comments

Remove defaults, require the params be passed if required by API

erichare avatar Nov 07 '23 17:11 erichare

This is especially evident in ops.py which would need some love (and ample work in digging through the docs + challenging stuff for better testing)

hemidactylus avatar Nov 20 '23 23:11 hemidactylus

@hemidactylus do you think this can now be closed in favor of the love to ops task, which of course requires a ton of work.... but with the db.py functions it seems we're in a much better spot than we were, and can maybe handle on a case by case basis?

erichare avatar Feb 08 '24 01:02 erichare

closing as core is being (slowly) abandoned in favour of "pure idiomatic"

hemidactylus avatar Jun 07 '24 14:06 hemidactylus