Marc Garcia
Marc Garcia
That looks interesting, had a quick look at intake before. But I'll probably leave the project of porting this to intake to someone else. I don't really use mnist myself,...
Thanks for sharing @martindurant. Do you think it makes sense to move your class `MNISTImagesPlugin` to an `intake.py` file in my repo? Not sure if many people is using my...
@jonashaag seems like you didn't add the release note as requested, do you mind adding it? Does it make sense to add a unit test for the new functions? Also...
> Do you want me to add unit tests? Personally I think it should be useful. Probably just one parametrized to test the function for every type is enough.
The release note in the other PR is not accurate now. The changes in this PR won't be available until pandas 1.6/2.0, while for what you mention the release note...
We already released pandas 1.5 release candidate, and we are only backporting regressions to it, not new features, performance improvements. It's also unclear to me this will be merged before...
Thanks for the PR @srotondo. Do you mind reverting the unrelated changes (removing or adding blank lines) please? Also, we need to add a test that captures the problem, fails...
Thanks @srotondo, this is more readable now. But looks like you're somehow reimplementing the tests in [here](https://github.com/pandas-dev/pandas/blob/main/pandas/tests/tools/test_to_datetime.py#L949), no? Would be good to start by adding the exact case or test...
Thanks @srotondo that makes sense. Is there a reason why the tests you added are not next to the ones I mentioned? Seems like they should be next to each...
This is a quite simple issue to work on if you're new to contributing. Not much work to do here, so you can focus on learning. You should check the...