Chris Nicholson
Chris Nicholson
Just use liquid to trim it
Considering this is for a fun project, that sounds like the perfect opportunity to test something that might very well be broken
Here’s the example: https://web.dev/uses-rel-preconnect/ and the current code says to load it like this: ``` (function(e,t,n,i,s,a,c){e[n]=e[n]||function(){(e[n].q=e[n].q||[]).push(arguments)} ;a=t.createElement(i);c=t.getElementsByTagName(i)[0];a.async=true;a.src=s ;c.parentNode.insertBefore(a,c) })(window,document,"galite","script","{{site.url}}/assets/js/ga-lite.min.js"); galite('create', '{{site.google_analytics}}', 'auto'); galite('send', 'pageview'); ``` I don’t see how that...
So I would just put that somewhere else early on the page, I don't need to modify what's already there in the script, correct? I thought preconnect needed to be...
Here's another lighthouse issue I just came across
With regard to dry mode, the documentation says "Runs the action in dry mode. Files wont get changed", which I took to mean that the files would not get modified.
This seems to explain it:  https://stackoverflow.com/questions/49153426/weird-margin-bottom-behavior-with-safari-on-ios If there's nothing after the element, there's nothing for margin-bottom to "bounce from".
Bumping this
My current remote theme has icons stored in _data that have to be manually copied to work.