Pooya Parsa

Results 106 comments of Pooya Parsa

Smart Commenting are not working well at the moment.

**Kenjis**, you are right. I don't agree with the name `shield:publish` either, to be honest, I already chose `shield:custom`. However, `shield:make` is good, but you have to be careful, in...

> But the view command copies view files and fixes the Config file. Exactly. > `make` generates files from templates. Yes, if you want I can write it with `GeneratorTrait`.

> It seems the view command is the same as the part of `Publish Views?`. I haven't used `auth:publish` before, but that's what I see. I don't think we need...

@kenjis We have now documented the [customization details for views](https://datamweb.github.io/shield/customization/views/#change-views). I want to know we need `php spark shield:publish view` now?

@najdanovicivan I'm currently on mobile and need to review this PR on my PC. I'll get back to it soon.

@ludis Why do you allow null values for passwords? Have you validated the input before storing it? **And what is your plan to ensure the security of accounts with empty...

> Do you have a benchmark for this change? The presence of **Optimize** probably led to this question. It seems I made a mistake in choosing it, as my main...

> Are we actually calling an `attempt` method multiple times per request? I didn't quite understand your question, and I'm not sure how it relates to this PR. Could you...