shield icon indicating copy to clipboard operation
shield copied to clipboard

feat: Settings - Decouple from shield

Open najdanovicivan opened this issue 1 year ago • 3 comments

Description Decouple settings library so it is not required. Related to #1215

Checklist:

  • [x] Securely signed commits
  • [x] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [ ] Unit testing, with >80% coverage
  • [ ] User guide updated
  • [x] Conforms to style guide

najdanovicivan avatar Nov 04 '24 21:11 najdanovicivan

Yes, it would be great to decouple Shield and Settings packages. Personally, I don't see a lot of sense of having the Settings dependency here, because CodeIgniter already has BaseConfig to handle settings.

TwistedAndy avatar Jun 19 '25 07:06 TwistedAndy

@datamweb What else is needed for this one to be merged ?

najdanovicivan avatar Oct 01 '25 06:10 najdanovicivan

@najdanovicivan I'm currently on mobile and need to review this PR on my PC. I'll get back to it soon.

datamweb avatar Oct 03 '25 15:10 datamweb