Ye Cao
Ye Cao
Make sense to me, the static file really needs a controller to manage. Thanks for the detailed description.
Thanks for this proposal. There are some tips for you. The CRD should contain the following configuration: 1. The [sidecar configuration](https://github.com/apache/skywalking-swck/blob/master/docs/java-agent-injector.md#configure-sidecar). As you said, the user can create a `sidecar...
> Hi @dashanji, > > I looked into the implements of SWCK, and saw the javaagent CRD is already exists. The javaagent CR is created by javaagent-controller when pods get...
> And here are questions to be clarified: > > 1. extend JavaAgent CRD or create new one? and the same question for controller. > 2. where and when to...
I think there is no breaking change, as the new CR could be considered as a Set of `annotation`.
> From deployment, breaking doesn't have to mean conflicting, such as whether legacy configs would be ignored? This should be considered a breaking change for an operator. In my mind,...
> > @wu-sheng @dashanji, from our discussion, i got the idea. we can create a new CR and operator. CR have the same annotations as pod level annotation for agents....
Agree! Configuration through CR is indeed clearer than configmap. However, the current agent configuration is mounted through configmap. We can use CR to manage the original configmap configuration, which makes...
Agree with @wu-sheng. Now is a good opportunity to configure the specific value of the optional plugin through a new CR. @Duncan-tree-zhou There are two ways to debug SWCK operator...
@sighingnow Could you please take a look at this?