Joshua Weber

Results 26 comments of Joshua Weber

@iansu / @mrmckeb Any feedback on this? Would be cool to have this merged so repositories which are using CRA (react-scripts in particular) would not be bothered by dependabot complaining...

In the current documentation of CloudFormation for the RDS Proxy it seems that the SQL Server engine family is not yet added. See here [https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-rds-dbproxy.html](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-rds-dbproxy.html). When this is added, the...

@corymhall I added a section in the readme for the usage of the repository created by the pull through cache rule. I took the example from this re:Invent talk actually:...

Tbh I am also quite surprised that there is not even a response by the maintainers to this pull request.

@gaearon Can we close this pull request? Or is it maybe a good idea to bump the dependency to a newer version even if the vulnerability is not affecting react-scripts?...

@peterwoodworth Since you commented on the original issue - could you review this PR please? I would appreciate the feedback! ❤️

@peterwoodworth I'm working on this since some time now and I don't really have an idea how I can properly test this. 1. Integ-Snapshot testing is not really good because...

@peterwoodworth I can now continue working on this feature again. Sorry for the delay! I have added the region prop to the `fromLookup` and `fromVpcAttributes` methods and used `fromVpcAttributes` in...

@peterwoodworth I just saw that I did not rebase this branch very well, but I think everything is fine. At least the changes still look good :) So please excuse...