Kyle Daruwalla
Kyle Daruwalla
Anymore clarity on this? My interpretation is that it is just #1468 in which case we can close.
Mapping to an indices or one-hot space is a standard data transformation for using a layer like `Embedding`. So I would say it's not a necessary feature for the layer....
Should this be re-targeted for master?
Looks like you need a rebase too
@manikyabard are you still up for rebasing this and moving forward? We ought to close up this loose end.
> Maybe we can discuss this further in the next community call. Yeah, sounds good!
Summarizing what was discussed on the call: - the issue is that the paths for `AbstractVector{
That looks right but you won't need to special case for `Embedding` anymore. It should go through the `NNlib.gather` rule automatically.
Can you add a test for `outputsize` of `Embedding`?
Probably the easiest option is to use Publish.jl, Documenter.jl, or Pollen.jl to host a "docs" site that is really all the tutorials. And spend a bunch of time on the...