Kyle Daruwalla
Kyle Daruwalla
A couple comments: - the RNG stored with the model is different in pre-1.7 vs. post-1.7; Metalhead.jl should probably have artifacts for both if it supports 1.6. Can you take...
Actually let's fix the RNG issue directly in Flux. I'll whip up a PR soon.
Okay now that I am at my desk and I can see the error in more detail, this isn't something that we need to fix in Flux. Flux will skip...
Nice docs appear to be working
Doesn't `is_differentiating` make sense from the user's perspective? Like ```julia function myf(x, y) if is_differentiating(myf, x, y) # do something special else # normal end end ``` I think we...
Presumably, no, it does not make sense to overload specific functions. If you want that behavior, then why even have `is_X` as a check at all in the definition of...
If I want the function to work regardless of AD system, then I need to check all (assuming I care about all of them). You could certainly write `any(within_gradient, (x,...
> it doesn't significantly change the logic of basic case? Yeah that was the goal here. I wanted to refactor the code as part of logical changes, so I pulled...
> And perhaps it's worth adding the AnonymousWalk idea, maybe it prints a depwarn... then 0.4 will in practice probably not break anyone's code. This is now in there. I...
Okay this now has #39 changes as well. Should be ready for another review.