Darrel

Results 511 comments of Darrel

In reviewing this thread, the main issue that stands out to me is we have two distinct intents for this feature we are calling "overlays": 1) It allows us to...

An extends object proposed by @MikeRalphson ``` openapi: 3.1.0 extends: target: https://raw.githubusercontent.com/OAI/OpenAPI-Specification/master/examples/v3.0/petstore.yaml overlayMethod: annotation servers: - url: http://localhost/v1 ```

Add support for x-ms-discriminator here https://github.com/microsoft/OpenAPI.NET/blob/vnext/src/Microsoft.OpenApi/Models/OpenApiDiscriminator.cs#L49

In order to identify derived types we will need to replace all $refs to base types with the following: ``` oneOf: - $ref: '#/components/schemas/microsoft.graph.directoryObject' - $ref: '#/components/schemas/microsoft.graph.user' - $ref: '#/components/schemas/microsoft.graph.group'...

More details are explained here https://github.com/microsoftgraph/msgraph-sdk-powershell/issues/19

@peombwa Is the oneOf essential for enabling discriminators or is it just a nice to have?

I would agree when we are not explicitly doing a new Type().

Is there an annotation to say "we don't support $ref"? Shouldn't $ref always be supported by workloads?

If we change the production of clean metadata to be based on the schemas folder, we will have the schemas update PR as a gate. Currently we are pulling from...