python-bip380
python-bip380 copied to clipboard
darosior
Bitcoin Output Script Descriptors with Miniscript extension
Resolves https://github.com/darosior/python-bip380/issues/30
The `hash160` implementation at https://github.com/darosior/python-bip380/blob/d2f5d8f5b41cba189bd793c1081e9d61d2d160c1/bip380/utils/hashes.py#L14-L17 uses hashlib to create a `ripemd160` digest. The `ripemd160` digest is not among [hashlib's guaranteed algorigthms](https://docs.python.org/3/library/hashlib.html) so this function may fail on some platforms with...
From [`README`](https://github.com/darosior/python-bip380/blame/d2f5d8f5b41cba189bd793c1081e9d61d2d160c1/README.md#L34): > This library provides an implementation of Segwit-native Output Descriptors and of Miniscript (to be used within `wsh()` descriptors), with a minimal amount of dependencies. Indeed I see...
I would like to ask about the current state of this library. In the [`README`](https://github.com/darosior/python-bip380/blob/d2f5d8f5b41cba189bd793c1081e9d61d2d160c1/README.md#wip-this-is-not-ready-for-any-real-use), I see you say: > WIP: this is not ready for any real use! >...
The parsing from script logic is a bit convoluted. I was confused especially about the non-terminal parsing logic in #23 when introducing `multi_a`. I should have another look at it...
We have this calculation for the number of executed OPs and the number of stack elements. It would be nice to implement it for the witness size as well, as...
When parsing a `multi` from Script we treat it as a non-terminal fragment. It's a terminal so it should be treated as such. In this function: https://github.com/darosior/python-bip380/blob/7b79c4719d3d311dec9c7bc5e6d63c79608a3b42/bip380/miniscript/parsing.py#L255-L260 https://github.com/darosior/python-bip380/blob/7b79c4719d3d311dec9c7bc5e6d63c79608a3b42/bip380/miniscript/parsing.py#L289-L319