Antoine Poinsot

The parsing from script logic is a bit convoluted. I was confused especially about the non-terminal parsing logic in #23 when introducing `multi_a`. I should have another look at it...

Witness size worst case calculation

1

We have this calculation for the number of executed OPs and the number of stack elements. It would be nice to implement it for the witness size as well, as...

When parsing a `multi` from Script we treat it as a non-terminal fragment. It's a terminal so it should be treated as such. In this function: https://github.com/darosior/python-bip380/blob/7b79c4719d3d311dec9c7bc5e6d63c79608a3b42/bip380/miniscript/parsing.py#L255-L260 https://github.com/darosior/python-bip380/blob/7b79c4719d3d311dec9c7bc5e6d63c79608a3b42/bip380/miniscript/parsing.py#L289-L319

Github Actions should do. Need to get libbitcoinconsensus, so it's not as trivial as the default Python GA.

Doc: add a comment referencing past vulnerability next to where it was fixed

3

It is useful when reading code to have context about why it is written or behaves the way it does. Some instances in this PR may seem obvious but i...

GUI freezes upon inputing unreachable Electrum server in settings of bitcoind-using Liana wallet

2

Testing Electrum support by switching my Liana wallet to Electrum, if i input an incorrect or unreachable server it just freezes the GUI.