Antoine Poinsot
Antoine Poinsot
Actually, this and #31600 can go in either order.
I think `curtime` and `mintime` should be using the same rules. I think both should be set such as to not support a timewarp attack, whether it is to not...
Do people think i should change the value of the coinbase transaction used in the fuzz test here as well? I previously kept it along with the PR introducing validation...
I have added a commit to also set nLocktime / nSequence for coinbase transactions created in fuzz targets. > The churn in the first commit is pretty annoying. @Sjors (from...
> I think you lost the comment announced here: [#32155 (comment)](https://github.com/bitcoin/bitcoin/pull/32155#discussion_r2056629920) > > Other than it looks good. I did not: https://github.com/bitcoin/bitcoin/pull/32155/commits/67267b147f8c48e0775602395fba9db0105dccf4#diff-6b810fb346def9cc80a9d9ab75184dd9f41c4ac63493135a7bdfcb98f75b1ce8R39 > Failure in `interface_usdt_coinselection` seems to be an...
It took me a while to remember the context here, since we had those discussions offline. I'll try to put a short summary here for anybody else who did not...
> This doesn't fully fix the fact that 1p1c is disrupted, because the parent is still not requested (its txid is AlreadyHave). Couldn't `AlreadyHave()` be tweaked to optionally not look...
Yes what i meant is "we now rely on something else for which it's pretty bad if one peer can block us from seeing a transaction". Changed the wording, thanks.
Yes, especially if we consider the costs to mitigating this. We shouldn't impose to all Bitcoin nodes on the network to perform 3 times expensive Script validation just for some...