Antoine Poinsot

I don't think this achieves much to be honest. It's good to be able to make the signer display the address, but if you assume the laptop is compromised (the...

I wrote a regression unit test for this: https://github.com/darosior/bitcoin/commit/d23ffe08ef42475dcd40a13857cd775ac98e0270. It's failing on master but also on this PR. Curiously i had to introduce a new test case with a descriptor...

@achow101 > Good catch, added that. Looks like you didn't. > It helped uncover another place where the node needs to be cloned Ugh. I should have caught that. Good...

Let's have a link to the documentation of each device in our own doc. No need for it to be in the GUI, nor for us to duplicate the content...

Meh on asking root. Also this strikes me as not a priority given it's Linux-specific. It's most likely only affecting a small percentage of our users, which will only get...

I think this should be part of a broader "allow to sort / filter / search for coins" effort to make sure the UI/UX is consistent overall.

The code in this pull request is of good quality and is well tested, but it's not clear to me what's the goal with this pull request nor how it...

Technically there no "too large indices", those are just the hardened indices. This would fail if the `BIP32` object is created from a public key. I think i did this...

I'm having trouble following what's happening here. You first generate 500 blocks, paying to a Liana wallet address in the coinbase transaction of each block, right? All those payments are...

Thanks for working on standardizing this. Let me state in advance that i think this is already an improvement over the current situation with a non-standardized scheme used by multiple...