Antoine Poinsot

Is there anything left to do here? I don't know about the implementation, but i unloaded my lianad watchonly wallet from my local mainnet node for a couple days in...

Just a self reminder to re-assess the approach here in light of the bugs with the way we were connecting the logs from bitcoind: https://github.com/wizardsardine/liana/pull/773.

> Just a self reminder to re-assess the approach here in light of the bugs with the way we were connecting the logs from bitcoind: #773. Since this is using...

Reading the logs from the file we write them to certainly sounds more roundabout and brittle (as in there is more moving parts, more could go wrong). Another avenue i...

Concept ACK.

In order to test this PR i implemented a PoC of a Rust wallet (using [`BDK`](https://github.com/bitcoindevkit/)) consuming the `Chain` interface introduced here. I think it's also a good example of...

tested ACK 395d5eed0475558de2c2a66914d5a5814ce38f3c I've tested this with the Rust wallet PoC i mentioned earlier: https://github.com/bitcoin/bitcoin/pull/29409#issuecomment-2524055170. This tool exercises the following methods: `getHeight`, `getBlockHash`, `hasBlocks`, `findAncestorByHeight`, `findAncestorByHash`, `findCommonAncestor`, `initMessage`, `showProgress` and...

I found another segmentation fault in updating my previous ACK to the latest tip of this PR. Here are minimal steps to reproduce: 1. Run a `bitcoin-node` from this PR....

Concept NACK. This introduces dead code and i don't think the justification for this meets the bar for touching consensus code.

Oh what a nice tool ! I'm planning to improve [`hsmtools`](https://github.com/ElementsProject/lightning/blob/master/tools/hsmtool.c) maybe we should combine efforts ? I'll add a manpage and propose to add it to install for next...