Antoine Poinsot

Results 549 comments of Antoine Poinsot

The "deposit split project" would help here as we would batch small inputs to create a vault of a given threshold.

Can you remove the merge commit? I'll merge it afterward.

Needs rebase @Sam071100

Interestingly the Win part of `libc` has `chmod` https://github.com/rust-lang/libc/blob/36a6a8e254db89cd31d178b4ba102055ceabf9a8/src/windows/mod.rs#L376-L379

> What should we do if the user decides to send funds to a CPFP address? I think we should for now duplicate it, since the CPFP output value computation...

We do sometimes test them, as discussed on mattermost (eg test_large_spend). But i'm not opposed to forbidding large CSVs, as that's better than officially supporting but undertesting them.

We started to fallback to generation in new code, but old one should be ported too.

> I somehow make you sign a tx without passing from revault, then if you want to cancel OOOPSS revault broken Could you detail the vector?