Antoine Poinsot
Antoine Poinsot
And it's back again! All PRs seem to hit it now. For instance #388
I just encountered this. Here is the datadir, the failing test was `test_large_spend`. [failed_store_sig_test_datadir.tar.gz](https://github.com/revault/revaultd/files/8602333/failed_store_sig_test_datadir.tar.gz)
Since #404 at least we don't recompile entirely all binaries.
Repro on aquarium: - Start `stk0d` - Run ```for i in `seq 30`; do bcli sendtoaddress `stk0cli getdepositaddress |jq -r .result.address` 1 && bcli generatetoaddress 1 `stk0cli getdepositaddress |jq -r...
Alright, it's because of generating block to a deposit address. https://github.com/revault/revaultd/blob/7cd856d5a345319cebc815aa61f3b66cebb48b86/src/bitcoind/interface.rs#L1161 https://github.com/revault/revaultd/blob/7cd856d5a345319cebc815aa61f3b66cebb48b86/src/bitcoind/interface.rs#L1183-L1189 This above does not take into account the "immature" category.
Yeah, spurious failure fixed by #361 . Rebasing on master should fix it.
Indeed they aren't. So my best guess is still the same.
We should test for error cases too, such as not having enough funds available. Currently the RPC call would not error but would only log...
Is this ready for review?