Darius Letterman

Results 16 comments of Darius Letterman
trafficstars

> @dariusclay to comment on plans for https://github.com/open-telemetry/opentelemetry-dotnet-contrib/tree/main/src/OpenTelemetry.Extensions.Enrichment as well. We should try and keep a single solution, unless there is a strong reason to have multiple... The extensions mentioned...

> * `Microsoft.Extensions.Telemetry.Abstractions` does support enrichment, but it also completely replaces the `ILoggerFactory` with its own implementation. Not sure if AzureMonitor could/would want to do that. > * Should we...

Can you provide a minimal reproduction of this issue using il-repack? It would help with investigations.

With il-repack, it can be configured to not internalize specific types. Do you know if this is possible to use in your case? ``` - /internalize[:] sets all types but...

> I'm unsure that having 2 public types with the same name will solve the issue. There's also this `/union` but not sure how that will look either without actually...

@hansmbakker your case is a little different than the one in the original post. When including the `Microsoft.Extensions.Http.Resilience` package, it replaces the .NET logging generator with the .NET extensions logging...

@hugoqribeiro we can alter the logic to search for a public attribute. Although, I am curious if using the il-repack options `internalize` + `union` works for you?

To the original discussion -- I've narrowed down the issue and created a unit test that captures the problem during symbol loading. Will publish a PR with the changes soon,...

@hugoqribeiro note that this will occur if any of the following types are internalized by il-repack ``` "Microsoft.Extensions.Logging.LoggerMessageAttribute" "Microsoft.Extensions.Logging.LogPropertiesAttribute" "Microsoft.Extensions.Logging.TagProviderAttribute" "Microsoft.Extensions.Logging.TagNameAttribute" "Microsoft.Extensions.Logging.LogPropertyIgnoreAttribute" "Microsoft.Extensions.Logging.ITagCollector" "Microsoft.Extensions.Logging.ILogger" "Microsoft.Extensions.Logging.LogLevel" "Microsoft.Extensions.Compliance.Classification.DataClassificationAttribute" "Microsoft.Extensions.Compliance.Classification.NoDataClassificationAttribute" ```