Dario Russi

Results 46 comments of Dario Russi

I was going to review this today (going through my list of requested review) and noticed is really old and with conflict. Sorry I did not get to this sooner,...

> By the way, the primary conservation check is in fact called during reconfiguration. The one at genesis is just to initialize it. We will need to deal with both...

made a change to create perpetual tables outside the `AuthorityStore`, let's see if it seems reasonable. Thanks!

> > I assume we cannot just create a new VM on-the-fly for the conservation check? > > We can do this, but then it may involve doing a lot...

> Looks reasonable change to me. Now that we have empty_table outside there, I wonder if it could be used to simplify other things (not sure, but worth a quick...

ok this is ready so let's try to get a review and make sure everything is good

made suggested changes unless otherwise commented

in case it helps.... 1- go to `/crates/sui-framework/packages/sui-framework` 2- run `sui move test --coverage` 3- `sui move coverage summary` will give you a summary of the percentage coverage for every...

code is moved forward by @Bridgerz and @patrickkuo

the PR failed to verify framework code because of the old problem with new code using old framework module coming from the verifier cache. So we create a fresh VM...