Dario Piotrowicz

Results 94 issues of Dario Piotrowicz

move the logic in `cpSync` that overrides existing dest files from JavaScript to C++ increasing its performance ___ This is the type of perf improvement that this change makes: ![Screenshot...

c++
fs
needs-ci

Currently the [logic for filtering out watch related flags](https://github.com/nodejs/node/blob/25842c5e35efb45df169e591c775a3c4f853556d/lib/internal/main/watch_mode.js#L42-L55) before passing them to the watch target script is flawed, as it includes any flag (starting with `-`) that follows a...

author ready
needs-ci

When a function is added to one of the internal bindings its types should be added to the [internalBindings typings](https://github.com/nodejs/node/tree/main/typings/internalBinding) (so that the type can be picked up by IDEs...

meta

Aliases are forced to be lowercase, I don't believe this to be correct? For example, this is ok: ![Screenshot 2023-05-03 at 11 26 01](https://user-images.githubusercontent.com/61631103/235891983-94a7a70e-71e6-499d-a55a-12b2e592c4e1.png) But this isn't: ![Screenshot 2023-05-03 at...

(AFAIK) In CLI tools if you have aliases you can combine them together, for example if I have aliases `-a` and `-b` I can provide to the CLI a single...

add the new `--watch-kill-signal` to allow users to customize what signal is sent to the process on restarts during watch mode

semver-minor
lib / src
author ready
needs-ci

I noticed that the repl tab completion doesn't correctly handle computed properties targeted by strings. For example given the following context: ```js const obj = { one: 1 }; ```...

repl
needs-ci

refactor the test/parallel/test-repl-save-load.js file by: - making the tests in the file self-contained (instead of all of them sharing the same REPL instance and constantly calling `.clear` on it) -...

test
needs-ci

prior to these changes cpSync would copy directories using C++ logic only if the user didn't provide a filtering function to the cpSync call, the changes here make it so...

c++
fs
semver-major
blocked
needs-ci
commit-queue-squash