dario-br
dario-br
Isn't it this issue implemented in here? https://github.com/EC-DIGIT-CSIRC/sysdiagnose/blob/de2921b2dff3f7fe15b5890627a4d9b7cb214e5e/src/sysdiagnose/__init__.py#L231-L235
Sorry, in here instead @cvandeplas : https://github.com/EC-DIGIT-CSIRC/sysdiagnose/blob/de2921b2dff3f7fe15b5890627a4d9b7cb214e5e/src/sysdiagnose/__init__.py#L210-L222
What about the filename of the sysdiagnose file itself? It contains the the timestamp in iso format, where you can see the time deviation from UTC. Would that work?
Hi @itayfoT , could you please also remove the changes to the file ps_everywhere.py? And can you also share some performance tests that you did? @cvandeplas did some and initially...
Hey @itayfoT, thanks for the PR. Very much appreciated. But would you mind to remove the changes related to orjson in it? You have already opened another one PR #209...
While it remains an analyser, some code maybe reused/re-think with the existing unit test: [test/test_parsers.py](https://github.com/EC-DIGIT-CSIRC/sysdiagnose-internal/blob/9eb76a98366da44123b3403d955bc9bcb1068176/tests/test_parsers.py#L46)
The analyser output could also be simplified and just return the json, while leaving the html logic in a separate script.
For the moment we have a standalone command in [src/sysdiagnose/utils/file_stats_diff.py](https://github.com/EC-DIGIT-CSIRC/sysdiagnose/blob/c1866416f7b55cdbdeb0c94e19c1afdcc5887be9/src/sysdiagnose/utils/file_stats_diff.py) Diff command could be potentially added to the main command-line or as a separate one and add little by little...
In fact, we should define a bit more how do we want a parser/analyser report that. So far, unit testing expects exceptions thrown out to show failure. Maybe, a parser/analyser...
what about having something like: - status : OK, OK with WARNINGS, ERROR - list of warnings (also reported in the logging) - list of errors (also reported in the...