Darcy Parker

Results 26 comments of Darcy Parker

I agree that they should work the same on all platforms. I can't tell if this is a node/npm issue or an ant issue. Personally I am leaning towards it...

That sounds fair about only focusing on products that use `.node-version`. And you're right, someone can easily find the work-around method here by searching and elsewhere.

I can't approve this, but wanted to say I think this looks good and worth merging. There are edge cases where `a` and `b` do not have `Object.prototype` in its...

One suggestion is to add some unit tests to capture the requirement/need to test for `a.valueOf` and `a.toString`. ie create some objects like `Object.assign(Object.create(null), {a: 1, b: 2})` (which does...

Did you test this with `Map` and `Set`? `!a.keys().every(b.has)` seems flawed. `keys()` returns an `IterableIterator`. It does not have `.every()`. `typeof (new Map()).keys().every === 'undefined'`

I have the same issue... but found :NeovideToggleFullscreen defined in #923 helps as a workaround.

FYI: I updated this pull request based on feedback (and after being MIA for a bit). I still need to add use cases and a usage example. I will do...

A solution is now feasible with `ReadonlyTuple` which was implemented https://github.com/sindresorhus/type-fest/pull/383 It is not blocked by #284. I need to come back to this. I am sorry I have let...

I also like this fix because it supports #287.

See draft: https://github.com/sindresorhus/type-fest/pull/287 `export type OneOrMore = [T, ...T[]]; // NOrMore` If you want to require exactly one: `type RequireOnlyOne = [T]` (Not sure you need a type for this...)