Darby Johnston
Darby Johnston
Nice, I didn't know about the Python support. I tried a quick valgrind test on test_serializableCollection.cpp and the results look good, no memory leaks or bad accesses: ``` $ valgrind...
The OpenEXR SonarCloud report is interesting, even on a mature code base written by experienced developers it thinks it has found about 70 bugs, 40 security hotspots, and 9000 "code...
I think the "smells" can be useful but there are way too many of them enabled by default. It would be nice if SonarCloud had a slider that let you...
Hi and thanks for the feedback. I'm definitely not an expert in Windows development either, this is just what I found after some searching. > For all platforms, the __SSE4_1__...
I like the idea of using CMake options to explicitly enable the support. It's simple, documents what's available, and avoids the issue you bring up of compiling for different machines....
OK, I've made the changes we talked about at the TSC meeting: * Use CMake options for enabling SIMD support, defaulted to OFF * Add a few SIMD enabled runs...
Here are a couple performance comparisons on Windows 10 with a Ryzen 3900X compiled with VS 2022. The utility exrmakepreview was run three times and the results averaged. SIMD options...
Sorry, SSE2 support was previously enabled by default on Windows but not SSE4. Those numbers were showing the difference between SIMD being completely disabled and enabled. Here are the numbers...
Hi, sorry for the churn on this PR, I just updated it with more changes. I added runtime CPU detection for SSE2 and SSE4.1 in the ZIP code, similar to...
Thanks for taking the time to review the changes, is there anything else I need to do for the code to be merged?