dapptools

dapptools copied to clipboard

Pass deployed library state to dapp test

[]

## Description Deploying libraries can take a long time. One can easily skip this stage if we make it possible to save the deployed library state and pass it to...

namrapatel

convience methods for skipping library deployment

[{"_id":"63443ec1cd14df15ba5b7d90","body":"ref https:\/\/dapphub.chat\/channel\/dev?msg=XQmkeMBAFhmXaBWAp\r\n","issue_id":1660408402507,"origin_id":988086450,"user_origin_id":8930559,"create_time":1638894742,"update_time":1638894742,"id":1665416897585,"updated_at":"2022-10-10T15:48:17.584000Z","created_at":"2022-10-10T15:48:17.584000Z"}]

deploying libraries can take a long time. One can easily skip this stage if we make it possible to save the deployed library state and pass it to `dapp test`:...

MrChico

treating reverts in hevm equivalence

[]

I think its not strictly sound to ignore the revert reasons if we want to think of things as composable....

MrChico

seth sig / seth calldata: handle tuple types

[{"_id":"63443e21cd14df15ba5b7d34","body":"https:\/\/github.com\/dapphub\/dapptools\/issues\/820 is this issue related?","issue_id":1660408402510,"origin_id":973213324,"user_origin_id":216636,"create_time":1637265615,"update_time":1637265615,"id":1665416737503,"updated_at":"2022-10-10T15:45:37.503000Z","created_at":"2022-10-10T15:45:37.503000Z"},{"_id":"63443e21cd14df15ba5b7d35","body":"I've done this in a branch along with a bunch of other abi stuff. Will make a pr soon.","issue_id":1660408402510,"origin_id":974902053,"user_origin_id":18486361,"create_time":1637531442,"update_time":1637531442,"id":1665416737507,"updated_at":"2022-10-10T15:45:37.507000Z","created_at":"2022-10-10T15:45:37.507000Z"}]

The abi parser in hevm does not currenlty support tuple types ([ref](https://github.com/dapphub/dapptools/blob/1729e1d87319fc0112e18536d9bc600cb1f3f623/src/hevm/src/EVM/ABI.hs#L511)). We need to implement this to be able to handle tuple types for `seth sig` and `seth calldata`.

d-xo

Test function that takes a struct argument breaks fuzzer/symbolic executor

[{"_id":"63443f658402fb318b6fca4c","body":"hmm, no it _should_ work, but I guess something might be wrong with the encoder","issue_id":1660408402514,"origin_id":968116633,"user_origin_id":8930559,"create_time":1636829217,"update_time":1636829217,"id":1665417061894,"updated_at":"2022-10-10T15:51:01.893000Z","created_at":"2022-10-10T15:51:01.893000Z"},{"_id":"63443f658402fb318b6fca4d","body":"i'm having the same issue. any workaround?","issue_id":1660408402514,"origin_id":973164577,"user_origin_id":216636,"create_time":1637261882,"update_time":1637261882,"id":1665417061904,"updated_at":"2022-10-10T15:51:01.903000Z","created_at":"2022-10-10T15:51:01.903000Z"},{"_id":"63443f658402fb318b6fca4e","body":"the issue seems to be about method signature lookup. look at this trace of a successful call to a function that takes a struct as an argument (`BreedingColor::[unknown method]` on `setUp`):\r\n```\r\n$ dapp test -m testColorRequest\r\nRunning 1 tests for test\/dapptools\/BreedingColor.t.sol:BreedingColorTest\r\n[BAIL] testColorRequest()\r\n\r\nFailure: testColorRequest\r\n test\/dapptools\/BreedingColor.t.sol:BreedingColorTest\r\n \u251c\u2574constructor\r\n \u251c\u2574setUp()\r\n \u2502 \u251c\u2574create MockLink@0xCe71065D4017F316EC606Fe4422e11eB2c47c246 (test\/dapptools\/BreedingColor.t.sol:17)\r\n \u2502 \u2502 \u2514\u2574\u2190 2977 bytes of code\r\n \u2502 \u251c\u2574create BreedingColor@0x185a4dc360CE69bDCceE33b3784B0282f7961aea (test\/dapptools\/BreedingColor.t.sol:18)\r\n \u2502 \u2502 \u251c\u2574RoleGranted() (node_modules\/@openzeppelin\/contracts\/access\/AccessControl.sol:200)\r\n \u2502 \u2502 \u251c\u2574RoleGranted() (node_modules\/@openzeppelin\/contracts\/access\/AccessControl.sol:200)\r\n \u2502 \u2502 \u251c\u2574RoleGranted() (node_modules\/@openzeppelin\/contracts\/access\/AccessControl.sol:200)\r\n \u2502 \u2502 \u2514\u2574\u2190 16256 bytes of code\r\n \u2502 \u251c\u2574call BreedingColor::[unknown method](0x592f4d8700000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000) (test\/dapptools\/BreedingColor.t.sol:24)\r\n \u2502 \u2502 \u2514\u2574\u2190 0x\r\n \u2502 \u2514\u2574call MockLink::mint(address,uint256)(BreedingColor@0x185a4dc360CE69bDCceE33b3784B0282f7961aea, 666) (test\/dapptools\/BreedingColor.t.sol:25)\r\n \u2502 \u251c\u2574Transfer(666) (node_modules\/@openzeppelin\/contracts\/token\/ERC20\/ERC20.sol:258)\r\n \u2502 \u2514\u2574\u2190 0x\r\n \u2514\u2574testColorRequest()\r\n \u251c\u2574call BreedingColor::requestBreeding(uint256,uint256,uint256)(0, 0, 0) (test\/dapptools\/BreedingColor.t.sol:41)\r\n \u2502 \u2514\u2574error Revert 0x (contracts\/normal_deployment\/BreedingColor.sol:146)\r\n \u2514\u2574error Revert 0x (test\/dapptools\/BreedingColor.t.sol:41)\r\n```","issue_id":1660408402514,"origin_id":973206264,"user_origin_id":216636,"create_time":1637265017,"update_time":1637265017,"id":1665417061919,"updated_at":"2022-10-10T15:51:01.919000Z","created_at":"2022-10-10T15:51:01.919000Z"}]

I have a small test contract like this: ```solidity pragma solidity 0.7.6; pragma abicoder v2; import {DSTestPlus} from "solmate/src/tests/utils/DSTestPlus.sol"; import {MockCrossDomainMessenger} from "nova/contracts/mocks/MockCrossDomainMessenger.sol"; import {L1_NovaExecutionManager} from "nova/contracts/L1_NovaExecutionManager.sol"; contract ExecutionManagerTest is...

transmissions11

An error occurred during the installation

[]

``` curl https://dapp.tools/install | sh % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 857 100 857 0 0 872...

foxundermoon

`unexpected symbolic argument` for prove test with single `address` argument

[{"_id":"63442d60cd14df15ba5b6f69","body":"You would have to look into which opcode this error is thrown on to get a clue about what specifically is not supported here, I agree that it looks like this should be doable","issue_id":1660408402518,"origin_id":968117768,"user_origin_id":8930559,"create_time":1636829686,"update_time":1636829686,"id":1665412448148,"updated_at":"2022-10-10T14:34:08.147000Z","created_at":"2022-10-10T14:34:08.147000Z"},{"_id":"63442d60cd14df15ba5b6f6a","body":"How can I find which opcode? The debugger crashes running the test too","issue_id":1660408402518,"origin_id":968131450,"user_origin_id":26209401,"create_time":1636835380,"update_time":1636858835,"id":1665412448152,"updated_at":"2022-10-10T14:34:08.151000Z","created_at":"2022-10-10T14:34:08.151000Z"},{"_id":"63442d60cd14df15ba5b6f6b","body":"Whatever opcode it crashes on if you step carefully would be the culprit","issue_id":1660408402518,"origin_id":968187743,"user_origin_id":8930559,"create_time":1636854032,"update_time":1636854032,"id":1665412448155,"updated_at":"2022-10-10T14:34:08.155000Z","created_at":"2022-10-10T14:34:08.155000Z"},{"_id":"63442d60cd14df15ba5b6f6c","body":"hmm ok the debugger doesn't actually seem to crash anymore, just show that the test failed without any assertion violations or reverts? \ud83e\udd14 \r\n\r\nhttps:\/\/asciinema.org\/a\/FRAL9R3u42exwNWtp3FVCL0l3","issue_id":1660408402518,"origin_id":968197456,"user_origin_id":26209401,"create_time":1636859619,"update_time":1636859619,"id":1665412448158,"updated_at":"2022-10-10T14:34:08.158000Z","created_at":"2022-10-10T14:34:08.158000Z"}]

I have a simple test function that takes a single address arg: ```solidity function proveConnectingExecutionManager(address newExecutionManager) public { registry.connectExecutionManager(newExecutionManager); assertEq(registry.L1_NovaExecutionManagerAddress(), newExecutionManager); } ``` https://github.com/Rari-Capital/nova-invariants/blob/4d1a9c9a4aa929314e82da79b6d52c980506c57e/src/Registry.t.sol#L31 The `connectExecutionManager()` function is simple: ```solidity...

transmissions11

hevm: thread blocked indefinitely in an MVar operation

[]

I see this error running `dapp test --coverage` in the [Solmate repo](https://github.com/rari-capital/solmate) ``` hevm: internal error: op ix CallStack (from HasCallStack): error, called at src/EVM/UnitTest.hs:249:21 in hevm-0.48.1-68JBNYehi12HotjGf8Zowl:EVM.UnitTest hevm: internal error:...

transmissions11

automatic gas estimation

[{"_id":"63443776fa5d322eb9342a47","body":"Very nice, been wanting this for some time. I have fixed ci on master, could you rebase so we can run it again?","issue_id":1660408402523,"origin_id":962601828,"user_origin_id":8930559,"create_time":1636288016,"update_time":1636288016,"id":1665415030844,"updated_at":"2022-10-10T15:17:10.843000Z","created_at":"2022-10-10T15:17:10.843000Z"},{"_id":"63443776fa5d322eb9342a48","body":"This should be good to go now. I've made a couple of changes so that instead of directly calling eth_estimateGas, I make all gas estimations through `seth estimate` (which I made a slight modification to).\r\n\r\nI also made sure to do this gas estimation in both `seth send` and `seth mktx`. This is because if you use an RPC signer, just adding the estimation in `seth mktx` is not sufficient.","issue_id":1660408402523,"origin_id":962780488,"user_origin_id":16858330,"create_time":1636342134,"update_time":1636342134,"id":1665415030851,"updated_at":"2022-10-10T15:17:10.850000Z","created_at":"2022-10-10T15:17:10.850000Z"}]

## Description Adds automatic gas estimation to `seth mktx` if `ETH_GAS` is not set. Since `seth mktx` is the underlying for `seth send` and `dapp create`, dapptools users will likely...

ncitron

Do not auto commit on init

[{"_id":"63443eecfa5d322eb9342ff4","body":"hmmmm, I'm not sure what we can do here? I think we would always want to install `ds-test` as part of `dapp init`, and since this requires adding a git submodule, we will always need to commit as part of `dapp init`. \r\n\r\nDid you have some ideas on how this could be improved?","issue_id":1660408402526,"origin_id":964110372,"user_origin_id":6689924,"create_time":1636461207,"update_time":1636461207,"id":1665416940574,"updated_at":"2022-10-10T15:49:00.573000Z","created_at":"2022-10-10T15:49:00.573000Z"}]

The commit during `dapp init` causes the process to fail if the user does not have a global git user and email defined. This prevents `ds-test` from being installed. I...

Dodecahedr0x